Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(inference/fal-ai): b64 response format argument #1149

Merged
merged 7 commits into from
Feb 10, 2025

Conversation

badayvedat
Copy link
Contributor

fal-ai endpoints are using sync_mode: true argument to receive the result as a base64 data uri
here is an example input/output with the parameter: https://fal.ai/models/fal-ai/flux/dev?share=c1793354-3994-44ef-a50b-31ef2ee9c90f

@julien-c
Copy link
Member

launching the CI to see if it passes the existing fal tests

@SBrandeis
Copy link
Contributor

SBrandeis commented Jan 29, 2025

Code looks good to me!

@badayvedat can you update the tapes.json file, please? It's used to replay HTTP responses in the CI.
You can do so by running test with VCR_MODE=cache:

VCR_MODE=cache pnpm run test

@badayvedat
Copy link
Contributor Author

thanks @SBrandeis ! updated them
fyi the new response objects are base64 images - which increased the file size of tapes.json significantly -

@SBrandeis SBrandeis self-assigned this Feb 4, 2025
Copy link
Contributor

@SBrandeis SBrandeis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you @badayvedat !

@SBrandeis SBrandeis merged commit f85f5f7 into huggingface:main Feb 10, 2025
4 checks passed
@badayvedat
Copy link
Contributor Author

thanks for looking into it and finalizing @SBrandeis !

@badayvedat badayvedat deleted the fix-fal-ai-base64-response branch February 10, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants