-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fireworks AI Conversational Models #1177
Conversation
c36b8b8
to
5540b2b
Compare
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok this is ready for review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM except some minor comments
packages/inference/README.md
Outdated
@@ -46,7 +46,7 @@ Your access token should be kept private. If you need to protect it in front-end | |||
|
|||
You can send inference requests to third-party providers with the inference client. | |||
|
|||
Currently, we support the following providers: [Fal.ai](https://fal.ai), [Replicate](https://replicate.com), [Together](https://together.xyz) and [Sambanova](https://sambanova.ai). | |||
Currently, we support the following providers: [Fal.ai](https://fal.ai), [Replicate](https://replicate.com), [Together](https://together.xyz), [Sambanova](https://sambanova.ai), and [Fireworks AI](https://fireworks.ai). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, we support the following providers: [Fal.ai](https://fal.ai), [Replicate](https://replicate.com), [Together](https://together.xyz), [Sambanova](https://sambanova.ai), and [Fireworks AI](https://fireworks.ai). | |
Currently, we support the following providers: | |
- [Fal.ai](https://fal.ai) | |
- [Fireworks AI](https://fireworks.ai) | |
- [Replicate](https://replicate.com) | |
- [Sambanova](https://sambanova.ai) | |
- [Together](https://together.xyz) |
given this list is expected to expand quite a lot, I'd turn the sentence into a bullet list + order alphabetically
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree with your suggestions, can you push them directly to this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done in 832a209
packages/inference/README.md
Outdated
@@ -68,6 +68,7 @@ Only a subset of models are supported when requesting third-party providers. You | |||
- [Replicate supported models](./src/providers/replicate.ts) | |||
- [Sambanova supported models](./src/providers/sambanova.ts) | |||
- [Together supported models](./src/providers/together.ts) | |||
- [Fireworks AI supported models](./src/providers/fireworks-ai.ts) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The links in this list are not correct anymore. Must be a link to the API route now:
- [Fal.ai supported models](https://huggingface.co/api/partners/fal-ai/models)
- [Fireworks AI supported models](https://huggingface.co/api/partners/fireworks-ai/models)
- [Replicate supported models](https://huggingface.co/api/partners/replicate/models)
- [Sambanova supported models](https://huggingface.co/api/partners/sambanova/models)
- [Together supported models](https://huggingface.co/api/partners/together/models)
- [HF Inference API (serverless)](https://huggingface.co/models?inference=warm&sort=trending)
(+ I would order alphabetically and put HF Inference in last position)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🔥
thanks for the contrib, @teofeliu! |
Added support for inference for Fireworks AI chat/instruct models