Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tasks: Add video-text-to-text task page #878

Merged
merged 19 commits into from
Sep 6, 2024
Merged

Tasks: Add video-text-to-text task page #878

merged 19 commits into from
Sep 6, 2024

Conversation

merveenoyan
Copy link
Contributor

@merveenoyan merveenoyan marked this pull request as ready for review September 2, 2024 12:14
@merveenoyan @julien-c
Update packages/tasks/src/tasks/video-text-to-text/about.md
73485b0 
Co-authored-by: Julien Chaumond <julien@huggingface.co>
merveenoyan and others added 5 commits September 4, 2024 13:53
@merveenoyan @pcuenca
Update packages/tasks/src/tasks/video-text-to-text/about.md
9960f90 
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@merveenoyan @pcuenca
Update packages/tasks/src/tasks/video-text-to-text/about.md
fa4d91d 
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@merveenoyan @pcuenca
Update packages/tasks/src/tasks/video-text-to-text/about.md
cc86687 
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@merveenoyan @pcuenca
Update packages/tasks/src/tasks/video-text-to-text/data.ts
5992301 
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@merveenoyan
Add opencv
9a0291c
@merveenoyan merveenoyan requested a review from pcuenca September 4, 2024 11:08
pcuenca
pcuenca reviewed Sep 5, 2024
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linter suggestions

packages/tasks/src/tasks/video-text-to-text/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/video-text-to-text/data.ts Outdated Show resolved Hide resolved
@merveenoyan
Copy link
Contributor Author

merveenoyan commented Sep 6, 2024 •
edited
Loading

IDK why linting on my local results in no change but here it fails works now

@merveenoyan
Copy link
Contributor Author

I did another passthrough and couldn't see anything that I'd change, would love an approval if there's no other thing y'all would change here

pcuenca
pcuenca approved these changes Sep 6, 2024
View reviewed changes
Copy link
Member

@pcuenca pcuenca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did a final pass and suggested a couple of minor nits, LGTM 🔥

packages/tasks/src/tasks/video-text-to-text/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/video-text-to-text/about.md Outdated Show resolved Hide resolved
packages/tasks/src/tasks/video-text-to-text/about.md Outdated Show resolved Hide resolved
merveenoyan and others added 4 commits September 6, 2024 13:15
@merveenoyan @pcuenca
Update packages/tasks/src/tasks/video-text-to-text/about.md
adaedfd 
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@merveenoyan @pcuenca
Update packages/tasks/src/tasks/video-text-to-text/about.md
4632795 
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@merveenoyan @pcuenca
Update packages/tasks/src/tasks/video-text-to-text/about.md
be95adc 
Co-authored-by: Pedro Cuenca <pedro@huggingface.co>
@merveenoyan
Merge branch 'main' into add-vt2t-task-page
498775b
@merveenoyan merveenoyan merged commit f9aa67d into main Sep 6, 2024
5 checks passed
@merveenoyan merveenoyan deleted the add-vt2t-task-page branch September 6, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zucchini-nlp zucchini-nlp zucchini-nlp left review comments

@julien-c julien-c julien-c left review comments

@pcuenca pcuenca pcuenca approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@merveenoyan @julien-c @pcuenca @zucchini-nlp