Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update recommended models for 2 tasks #883

Merged
merged 9 commits into from
Oct 16, 2024
Merged

Update recommended models for 2 tasks #883

merged 9 commits into from
Oct 16, 2024

Conversation

NielsRogge
Copy link
Contributor

Some minor updates for the recommended models of the "image segmentation" and "object detection" tasks:

  • "facebook/detr-resnet-50-panoptic" is pretty outdated and also not that good
  • "microsoft/beit-base-patch16-224-pt22k-ft22k" was linked in the object detection page, but it's an image classification model

cc @merveenoyan

Vaibhavs10
Vaibhavs10 reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@Vaibhavs10 Vaibhavs10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JFYI - @merveenoyan is updating these in this PR: #876

@merveenoyan
Copy link
Contributor

My PR is merged already, @NielsRogge can you lint?

merveenoyan
merveenoyan approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@merveenoyan merveenoyan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some changes, otherwise LGTM

packages/tasks/src/tasks/object-detection/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/object-detection/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-segmentation/data.ts Outdated Show resolved Hide resolved
packages/tasks/src/tasks/image-segmentation/data.ts Outdated Show resolved Hide resolved
NielsRogge and others added 5 commits October 16, 2024 15:56
@NielsRogge @merveenoyan
Update packages/tasks/src/tasks/object-detection/data.ts
c4c130e 
Co-authored-by: Merve Noyan <merveenoyan@gmail.com>
@NielsRogge @merveenoyan
Update packages/tasks/src/tasks/object-detection/data.ts
a070b1b 
Co-authored-by: Merve Noyan <merveenoyan@gmail.com>
@NielsRogge @merveenoyan
Update packages/tasks/src/tasks/image-segmentation/data.ts
e1028f0 
Co-authored-by: Merve Noyan <merveenoyan@gmail.com>
@NielsRogge @merveenoyan
Update packages/tasks/src/tasks/image-segmentation/data.ts
b64f1dd 
Co-authored-by: Merve Noyan <merveenoyan@gmail.com>
@NielsRogge
Merge branch 'main' into update_tasks
876caee
@merveenoyan merveenoyan merged commit f9ae194 into huggingface:main Oct 16, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vaibhavs10 Vaibhavs10 Vaibhavs10 left review comments

@merveenoyan merveenoyan merveenoyan approved these changes

@osanseviero osanseviero Awaiting requested review from osanseviero

@SBrandeis SBrandeis Awaiting requested review from SBrandeis SBrandeis is a code owner

@gary149 gary149 Awaiting requested review from gary149 gary149 is a code owner

@Wauplin Wauplin Awaiting requested review from Wauplin Wauplin is a code owner

@julien-c julien-c Awaiting requested review from julien-c julien-c is a code owner

@pcuenca pcuenca Awaiting requested review from pcuenca pcuenca is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NielsRogge @merveenoyan @Vaibhavs10