Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump version to 0.19 #1723

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Bump version to 0.19 #1723

merged 1 commit into from
Oct 13, 2023

Conversation

Wauplin
Copy link
Contributor

@Wauplin Wauplin commented Oct 12, 2023

Follow-up after 0.18 release.

InferenceAPI was announced to be removed by now but I don't think it's wise. Given how much it has being used in external libraries and scripts I think it's wiser to deprecate it with no real deadline (I've set v1.0 but not sure it'll happen someday^^).

@Wauplin Wauplin requested a review from LysandreJik October 12, 2023 12:47
@HuggingFaceDocBuilderDev
Copy link

HuggingFaceDocBuilderDev commented Oct 12, 2023

The documentation is not available anymore as the PR was closed or merged.

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (dd18be7) 49.19% compared to head (688048a) 82.53%.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #1723       +/-   ##
===========================================
+ Coverage   49.19%   82.53%   +33.33%     
===========================================
  Files          62       62               
  Lines        7265     7265               
===========================================
+ Hits         3574     5996     +2422     
+ Misses       3691     1269     -2422     
Files Coverage Δ
src/huggingface_hub/__init__.py 75.75% <100.00%> (ø)
src/huggingface_hub/inference_api.py 88.88% <ø> (+57.77%) ⬆️

... and 44 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@LysandreJik LysandreJik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jamesbraza
Copy link
Contributor

Would you be willing to hold off on this release for one day while I add support for pydantic v2? 😄

@Wauplin
Copy link
Contributor Author

Wauplin commented Oct 13, 2023

@jamesbraza Actually the 0.18.0 is already out since the beginning of the week: https://github.com/huggingface/huggingface_hub/releases/tag/v0.18.0.

This PR just sets the version to 0.19.0.dev0 until the 0.19 is properly released. But that will only be in a few weeks when we have enough new features to release. In any case you can always install huggingface_hub from the source so once pydantic v2 is merged, you'll be able to do

pip install git+https://github.com/huggingface/huggingface_hub@main

@Wauplin Wauplin merged commit 30f5ed4 into main Oct 13, 2023
16 checks passed
@Wauplin Wauplin deleted the prepare-for-0.19 branch October 13, 2023 06:21
@jamesbraza
Copy link
Contributor

Ah I see, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants