Remove black formatter to use only ruff #1783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
LysandreJik
approved these changes
Oct 30, 2023
There was a problem hiding this comment.
Great, thank you! Would be great to align with transformers/accelerate/diffusers/others
cc @charliermarsh, you might be interested :)
|
Thanks @LysandreJik for the review :) And immensely grateful @charliermarsh for the amazing work on Ruff ❤️ |
|
Amazing, thanks @Wauplin and @LysandreJik! So cool to see :) |
This was referenced Oct 31, 2023
Comment on lines
-184
to
185
| # Format with black | ||
| code = black.format_file_contents(code, fast=False, mode=black.FileMode(line_length=119)) | ||
|
|
||
| # Format with ruff | ||
| with tempfile.TemporaryDirectory() as tmpdir: | ||
| filepath = Path(tmpdir) / "__init__.py" |
There was a problem hiding this comment.
The call to ruff without arguments will not format but check.
See #27144 where we heavily rely on the formatting of the # Copied from
There was a problem hiding this comment.
Good catch!
Fixed this in #1824.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following https://astral.sh/blog/the-ruff-formatter, I suggest we remove
blackformatter completely. It was already not very used anyway. Made a few changes so that current code is formatted the same with bothblackandruffto reduce inconveniences for existing contributors.N°1 argument IMO is speed. N°2 is that it's convenient to have everything handled by the same tool.