Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests in CI are quite flaky lately. We have a
retry_on_transient_errors
wrapper to retry on OSError (git clone failed), TimeoutError or HTTP 502/504. But this wrapper just doesn't work (sorry I introduced it 2mo ago in #1725 🙄). This PR fixes this by usingpytest-rerunfailures
which seems to be far more robust and tested that doing it manually^^.Note that only tests run in CI are rerun on failure. I did not make it a default locally as it's not compatible with
--pdb
. (+flaky tests are never failing locally in my experience).