Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic idea would be to handle a directory path the same way we are handling a zip file. The abstraction let us navigate in the directory/zip file, check if subpath exists, is a file, is a dir, etc. Also allows to read the file as text or as bytes (lazy loading).
Goes together with the DDUF PR + this transformers' PR: huggingface/transformers#35173
Nothing is set in stone. Naming, specs, exposed methods, etc., everything can be changed/updated if needed. To be honest, I'm still very unsure this is a good idea. I find it elegant in theory but likely to be error-prone in practice + will require breaking changes in transformers. To be discussed...