Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix deprecated arg shared_memory #499

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

sanbuphy
Copy link
Contributor

@sanbuphy sanbuphy commented Jan 5, 2024

What does this PR do?

fix deprecated arg shared_memory

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@sanbuphy
Copy link
Contributor Author

sanbuphy commented Jan 5, 2024

@jiwaszki could you take a look ? thank you :)

Copy link
Contributor

@jiwaszki jiwaszki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @sanbuphy !

@echarlaix can you trigger CIs? Thank you in advance!

@jiwaszki
Copy link
Contributor

jiwaszki commented Jan 5, 2024

@sanbuphy BTW do you have free time to experiment with my older PR #429 ?
It needs to be refreshed. Overall the goal is to introduce share_outputs flags correctly into the pipelines without loosing data in the meantime. Maybe there are cases where copy can be omitted, it needs a little bit of exploration.
Would you like to do it as well? (separate PR ofc)

@sanbuphy
Copy link
Contributor Author

sanbuphy commented Jan 5, 2024

@sanbuphy BTW do you have free time to experiment with my older PR #429 ? It needs to be refreshed. Overall the goal is to introduce share_outputs flags correctly into the pipelines without loosing data in the meantime. Maybe there are cases where copy can be omitted, it needs a little bit of exploration. Would you like to do it as well? (separate PR ofc)

Sorry, could you descripe Overall the goal is to introduce share_outputs flags correctly into the pipelines without loosing data in the meantime. Maybe there are cases where copy can be omitted more detail ? i'm not sure i have got the meaning about into the pipelines without loosing data in the meantime and there are cases where copy can be omitted ; what should i do to profile this ? btw do you have discord ? maybe we can talk about this there

@jiwaszki
Copy link
Contributor

jiwaszki commented Jan 5, 2024

@sanbuphy sure, you can find me on Intel DevHub server or by my username jiwaszki_23704.

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @sanbuphy !

@echarlaix echarlaix merged commit 19fef90 into huggingface:main Jan 5, 2024
8 of 10 checks passed
PenghuiCheng pushed a commit to PenghuiCheng/optimum-intel that referenced this pull request Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants