Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add openvino export configs #568

Merged
merged 16 commits into from
Mar 14, 2024
Merged

add openvino export configs #568

merged 16 commits into from
Mar 14, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Feb 19, 2024 •
edited
Loading

What does this PR do?

enable export configs for openvino, this functional depends on huggingface/optimum#1698
(if it will not be accepted, I place copy of introduced functions here).

Motivation

  • unblock enabling new models directly in optimum-intel (original path support optimum -> wait official release -> support in openvino may be time-consuming for users), fast enabling path.
  • unbind from requirement that model should be exportable in onnx (openvino uses direct pytorch conversion as default path now that have different model representation and supported ops in comparison with onnx). It is possible that some of provided by me configs are also works with onnx out of the box and later can be moved in original optimum, but for enabling model in openvino, we do not require to check that

@eaidova eaidova force-pushed the ea/ov_export_configs branch 4 times, most recently from b08610f to 9d9e248 Compare February 19, 2024 14:39
@HuggingFaceDocBuilderDev
Copy link

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@eaidova eaidova force-pushed the ea/ov_export_configs branch from eb044a9 to c1064fd Compare February 20, 2024 09:02
@eaidova eaidova marked this pull request as ready for review February 21, 2024 08:12
@eaidova eaidova mentioned this pull request Feb 21, 2024
Closed
3 tasks
helena-intel
helena-intel approved these changes Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@helena-intel helena-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @eaidova this is awesome! I tested optimum-cli with Mixtral and it works well.

echarlaix
echarlaix reviewed Feb 22, 2024
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, thanks a lot @eaidova 🔥

optimum/exporters/openvino/__init__.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/model_configs.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Show resolved Hide resolved
echarlaix
echarlaix reviewed Feb 23, 2024
View reviewed changes
optimum/exporters/openvino/convert.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/convert.py Outdated Show resolved Hide resolved
@slyalin slyalin mentioned this pull request Feb 27, 2024
Merged
@eaidova eaidova force-pushed the ea/ov_export_configs branch from bbdca54 to 34351b1 Compare February 29, 2024 08:20
@eaidova eaidova requested a review from echarlaix February 29, 2024 13:22
echarlaix
echarlaix reviewed Feb 29, 2024
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @eaidova

setup.py Outdated Show resolved Hide resolved
tests/openvino/test_modeling.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/model_patcher.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/model_configs.py Outdated Show resolved Hide resolved
optimum/exporters/openvino/model_configs.py Show resolved Hide resolved
@eaidova eaidova force-pushed the ea/ov_export_configs branch 2 times, most recently from 41805d8 to 02889ac Compare February 29, 2024 16:35
@eaidova eaidova requested a review from echarlaix February 29, 2024 16:37
@eaidova eaidova force-pushed the ea/ov_export_configs branch 5 times, most recently from 1b29066 to 828dce1 Compare March 1, 2024 11:38
@eaidova eaidova force-pushed the ea/ov_export_configs branch 3 times, most recently from 0c651e1 to d599d41 Compare March 4, 2024 14:34
echarlaix
echarlaix approved these changes Mar 4, 2024
View reviewed changes
Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will merge after the next optimum release

optimum/exporters/openvino/model_patcher.py Outdated Show resolved Hide resolved
@eaidova eaidova force-pushed the ea/ov_export_configs branch from 04ab002 to 049ab53 Compare March 5, 2024 07:06
@eaidova eaidova force-pushed the ea/ov_export_configs branch from 049ab53 to 91016a8 Compare March 12, 2024 08:08
@echarlaix echarlaix merged commit 8880d2e into huggingface:main Mar 14, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echarlaix echarlaix echarlaix approved these changes

@helena-intel helena-intel helena-intel approved these changes

@AlexKoff88 AlexKoff88 AlexKoff88 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eaidova @HuggingFaceDocBuilderDev @AlexKoff88 @helena-intel @echarlaix