Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate use_auth_token #684

Merged
merged 7 commits into from
Apr 29, 2024
Merged

Deprecate use_auth_token #684

merged 7 commits into from
Apr 29, 2024

Conversation

IlyasMoutawwakil
Copy link
Member

What does this PR do?

This PR deprecates use_auth_token in favor of token

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@IlyasMoutawwakil
Copy link
Member Author

IlyasMoutawwakil commented Apr 24, 2024

I tried to add warning at the beginning of every function/method that used to accept use_auth_token, then only pass token wich occasionally gets assigned use_auth_token's value. This works with transformers and hugingface_hub functions/methods but not diffusers (some still take use_auth_token only which I commented in loaders)

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @IlyasMoutawwakil, could you add a test to OVModelIntegrationTest as done in optimum

@IlyasMoutawwakil
Copy link
Member Author

i added a test (that passes) but some cases still fail, like loading+exporting from a private repo, but it's an issue from optimum side.

@echarlaix echarlaix merged commit c287fba into main Apr 29, 2024
13 checks passed
@echarlaix echarlaix deleted the deprecate-use_auth_token branch April 29, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants