make unet and vae number of channels static#692
Conversation
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eaidova
force-pushed
the
ea/sd_static_channles
branch
2 times, most recently
from
af0fafb to
f18d43d
Compare
eaidova
force-pushed
the
ea/sd_static_channles
branch
from
f18d43d to
482197a
Compare
slyalin
left a comment
slyalin
left a comment
There was a problem hiding this comment.
Based on the description, it will simplify application code when exported OV model is being deployed without the need to hardcode internal parameters in the application or reading them from config files.
echarlaix
left a comment
echarlaix
left a comment
There was a problem hiding this comment.
LGTM, why not adding it to optimum instead ?
@echarlaix, I'll open the same PR to optimum too if you agree, I just want unblock some work on openvino side where these changes can simplify demo workflow as soon as possible |
works for me thanks @eaidova |
4 participants
What does this PR do?
uses static number of channels for unet and vae as this value is important for model architecture (number of channels for convolutions) and can not be changed in runtime and always expected to be the same like provided in config