Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default 4bit configs #702

Merged
merged 5 commits into from
May 29, 2024
Merged

Conversation

KodiaqQ
Copy link
Contributor

@KodiaqQ KodiaqQ commented May 8, 2024

What does this PR do?

Contains configuration updates based on the experiments from 135227 and following PR's:

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@KodiaqQ
Copy link
Contributor Author

KodiaqQ commented May 8, 2024

cc @AlexKoff88

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@echarlaix
Copy link
Collaborator

To fix the code style test you can do the following :

pip install .[quality]
make style

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @KodiaqQ

optimum/intel/openvino/configuration.py Outdated Show resolved Hide resolved
optimum/intel/openvino/configuration.py Outdated Show resolved Hide resolved
Co-authored-by: Ella Charlaix <80481427+echarlaix@users.noreply.github.com>
@KodiaqQ KodiaqQ requested a review from echarlaix May 29, 2024 11:08
@echarlaix echarlaix merged commit 70c1475 into huggingface:main May 29, 2024
11 checks passed
@KodiaqQ KodiaqQ deleted the nm/update_defaults branch July 15, 2024 07:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants