Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate transformers v4.36.0 #758

Closed
wants to merge 3 commits into from
Closed

Deprecate transformers v4.36.0 #758

wants to merge 3 commits into from

Conversation

echarlaix
Copy link
Collaborator

@echarlaix echarlaix commented Jun 10, 2024

Also fixes issue for OpenVINO export of arctic architectures patching for transformers < v4.37.0 https://huggingface.co/Snowflake/snowflake-arctic-instruct/blob/main/modeling_arctic.py#L1010

cc @helena-intel @eaidova

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@helena-intel
Copy link
Collaborator

If possible, it would be great if we could support transformers versions a bit longer. 4.36.2 was released about 6 months ago. That's not so long ago. For example LlavaMed 1.5 was released three weeks ago and needs transformers 4.36.2

@echarlaix
Copy link
Collaborator Author

If possible, it would be great if we could support transformers versions a bit longer. 4.36.2 was released about 6 months ago. That's not so long ago. For example LlavaMed 1.5 was released three weeks ago and needs transformers 4.36.2

Opened #764 to fix the arctic models export in the meantime, I'm ok with delaying this PR even though 6 months sounds reasonable to me, what's your expection in terms of support ?

@echarlaix echarlaix closed this Jun 18, 2024
@echarlaix echarlaix deleted the deprecate-trfs branch November 26, 2024 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants