Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default trust remove code for predefined datasets #768

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

echarlaix
Copy link
Collaborator

@echarlaix echarlaix commented Jun 17, 2024

Removing trust_remote_code=True when loading a dataset from PREDEFINED_SD_DATASETS :

for now loading automatically the dataset conceptual_captions when specified in the quantization config will fail as trust_remote_code=True is needed for datasets with a python loading script for datasets>=v2.20.0

cc @lhoestq

@echarlaix echarlaix marked this pull request as ready for review June 17, 2024 10:24
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@lhoestq
Copy link
Member

lhoestq commented Jun 17, 2024

I opened https://huggingface.co/datasets/google-research-datasets/conceptual_captions/discussions/3 to not require trust_remote_code on conceptual_captions

@echarlaix
Copy link
Collaborator Author

Thanks a lot @lhoestq

@echarlaix echarlaix merged commit 87d9c84 into main Jun 17, 2024
14 of 19 checks passed
@echarlaix echarlaix deleted the trust-remote-code branch June 17, 2024 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants