remove useless functions #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
echarlaix
approved these changes
Jun 26, 2024
Comment on lines
-135
to
-136
| def patch_decoder_attention_mask(model: "PreTrainedModel"): | ||
| """ |
There was a problem hiding this comment.
what is the smallest transformers version for which this can be deprecated ?
There was a problem hiding this comment.
transformers==4.35.0 can still work on this change from my tests. But transformers==4.34.0 failed with the following error:
Traceback (most recent call last):
File "/home/jiqingfe/jiqing_hf/HuggingFace/tests/workloads/text-generation/run_text-generation.py", line 120, in <module>
from optimum.intel import IPEXModelForCausalLM
File "<frozen importlib._bootstrap>", line 1075, in _handle_fromlist
File "/home/jiqingfe/miniconda3/envs/torch/lib/python3.10/site-packages/transformers/utils/import_utils.py", line 1272, in __getattr__
module = self._get_module(self._class_to_module[name])
File "/home/jiqingfe/miniconda3/envs/torch/lib/python3.10/site-packages/transformers/utils/import_utils.py", line 1284, in _get_module
raise RuntimeError(
RuntimeError: Failed to import optimum.intel.ipex because of the following error (look up to see its traceback):
No module named 'transformers.modeling_attn_mask_utils'
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
echarlaix
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't need patch prepare attention maks functions anymore in the latest transformers version.