Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix loading models from cache #820

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

eaidova
Copy link
Collaborator

@eaidova eaidova commented Jul 12, 2024

What does this PR do?

After these changes openvinotoolkit/openvino#24781 openvino will be not able to use symlinks as paths for reading models. symlinks are produced by HF Hub API during saving models in cache. This PR should resolve problem with reading models downloaded from hub

Fixes # (issue)

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?

@eaidova eaidova force-pushed the ea/resolve_symlinks_hf_hub branch from c22e52f to 41a56fd Compare July 12, 2024 09:26
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@echarlaix echarlaix merged commit 9ef6766 into huggingface:main Jul 12, 2024
13 of 17 checks passed
IlyasMoutawwakil pushed a commit that referenced this pull request Aug 6, 2024
IlyasMoutawwakil pushed a commit that referenced this pull request Aug 6, 2024
IlyasMoutawwakil pushed a commit that referenced this pull request Aug 6, 2024
IlyasMoutawwakil pushed a commit that referenced this pull request Aug 6, 2024
IlyasMoutawwakil pushed a commit that referenced this pull request Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants