Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ipex doc #828
Ipex doc #828
Changes from 20 commits
d7b0fc4
78f7c61
b531a72
90d9000
b39be97
a90cb23
e884158
2100cd9
84305bc
23f8756
644d197
fde311c
a9a2c38
4368205
c31696d
c5412da
291c73d
8772c51
39f27dd
1d8fc29
02fa235
4ed2620
770d82f
0a9ce3d
378144e
be7097d
21f06cf
ae8143a
9a25ac7
52bec25
d6153b7
8115bf6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the plan for the models format in the next release ? From my understanding we will stop using TorchScript, I'd prefer to wait for the next release once we have something that won't get deprecated, before adding it to the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you mean the Pytorch release? If so, it depends on the models performance under torch.compile. If all models can have an acceptable speed-up under
torch.compile
, we will removejit.trace
and applytorch.compile
; otherwise, we will keep torchscript or convert parts of models totorch.compile
, I will discuss with you before I take any actions.I don't think waiting for the next release is the best option since the
torch.compile
is not under our control. Currently,torch.compile
is not working on all models for all tasks; many performance regressions need to be fixed. We will apply thetorch.compile
one by one for models. Changing all models to compile without any issues is impossible for now, so it's a long-term project. Besides, we will not change the API in IPEXModel, so it's okay to deliver this ipex doc to users.