Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ipex button #881

Merged
merged 5 commits into from
Sep 12, 2024
Merged

ipex button #881

merged 5 commits into from
Sep 12, 2024

Conversation

jiqing-feng
Copy link
Collaborator

Add ipex button for better instruction.

@jiqing-feng jiqing-feng marked this pull request as ready for review August 28, 2024 06:52
@jiqing-feng
Copy link
Collaborator Author

jiqing-feng commented Aug 28, 2024

Hi @echarlaix @IlyasMoutawwakil , Could you please merge this PR since ipex doc has been merged, it could help users to find ipex doc well. Thx!

@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Copy link
Collaborator

@echarlaix echarlaix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know when we can start the refactorization with torch.compile ? This will lead to a lot of modifications for the ipex integration + model exported via TorchScript getting deprecated, so I'd be in favor to add the ipex button only after the planned refactorization

@jiqing-feng
Copy link
Collaborator Author

Do you know when we can start the refactorization with torch.compile ? This will lead to a lot of modifications for the ipex integration + model exported via TorchScript getting deprecated, so I'd be in favor to add the ipex button only after the planned refactorization

I am working on this by starting with seq2seq models, but we don't need to bond the 2 tasks cause I didn't see any relations btw the 2 tasks. We can have this button and enable torch.compile step by step.

@echarlaix echarlaix merged commit e70ff84 into huggingface:main Sep 12, 2024
16 checks passed
@jiqing-feng jiqing-feng deleted the ipex_button branch December 9, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants