fix switching between legacy and new processing for llava #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
eaidova
force-pushed
the
ea/fix_switch_between_legacy_preprocesing
branch
from
b356f6f to
044565a
Compare
AlexKoff88
approved these changes
Nov 6, 2024
eaidova
force-pushed
the
ea/fix_switch_between_legacy_preprocesing
branch
from
044565a to
bb90a76
Compare
eaidova
commented
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
currently the second token is always processed as legacy due to limitation with providing info between iterations that lead on perf issues on some platforms
Migration on usage new preprocessing significantly speedup inference on iGPU (>1s for the second token to 200ms for llava-1.5-7b-hf in fp32)
Before submitting