DOC Update a few places in the README #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix bits_and_bytes => bitsandbytes - add a few links - add mistral to list of supported models
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
approved these changes
Nov 20, 2023
There was a problem hiding this comment.
Thanks! Not sure about the rule, but I would say as long as it is present in a single mapping object, maybe @pacman100 can confirm
stevhliu
reviewed
Nov 28, 2023
Co-authored-by: Steven Liu <59462357+stevhliu@users.noreply.github.com>
I added a note about this in our internal docs discussion page, so that we don't forget about it. I'll go ahead and merge this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1151
A question: What is the criterion for a model to be considered to be "supported" for a given adapter? E.g. "ChatGLM" is listed as having support for all methods, but we only have an entry for it in
TRANSFORMERS_MODELS_TO_LORA_TARGET_MODULES_MAPPING, not inTRANSFORMERS_MODELS_TO_IA3_TARGET_MODULES_MAPPINGetc. So should we really put a ✅ in all those columns? For mistral, I only added a ✅ for LoRA, as that's the only entry for mistral that we have, even though I'm pretty sure we can just use the same settings for other adapters.