TST: Update torch.compile tests and docs #2332
Open
+23
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have tests to check if torch.compile works for various PEFT methods and "advanced" features (QLoRA, merging, ...). These tests are not run on a regular basis, but are triggered manually. As such, it was time to revisit them. So far, a few of these tests were marked as xfailing. All these tests are passing now. The reasons for this: - Presumably: New PyTorch version (I haven't checked older) - Loosening some tolerances - Remove a spurious argument added by torch.compile - Slightly adjust order of when torch.compile is called The docs have been updated to reflect these new findings.
githubnemo
approved these changes
Jan 23, 2025
| model.add_adapter("other", config) | ||
| model = self.compile(model, {}) | ||
| model.eval() |
There was a problem hiding this comment.
Is it a requirement to only call compile once?
There was a problem hiding this comment.
From my testing, torch.compile needs to be called after loading all adapters. I extended the docs to say so in my last commit.
... when using multiple adapters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have tests to check if
torch.compileworks for various PEFT methods and "advanced" features (QLoRA, merging, ...). These tests are not run on a regular basis, but are triggered manually. As such, it was time to revisit them.So far, a few of these tests were marked as
xfailing. All these tests are passing now. The reasons for this:torch.compiletests without changes leads to failures because of strictxfailtorch.compiletorch.compileis calledThe docs have been updated to reflect these new findings.
Note that the
torch.compiletests don't run on regular CI. I ran the tests locally and they passed for me.