Always call .to(device) if it was passed as an argument #583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes huggingface#582 where if setting torch.set_default_device('not cpu'), the device for the tensor ends up being the default device rather than the passed device.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #582 where if setting torch.set_default_device('not cpu'), the device for the tensor ends up being the default device rather than the passed device.
What does this PR do?
Fixes #582
NOTE: I could not find any development instructions in the repository after a brief search. This PR would be better with a test case that shows the problem and then another commit that fixes it but I am unfamiliar with maturin. Feel free to provide instructions or take my work and finish it.