[v4] Switch build system to use esbuild #1466
Conversation
|
Amazing -- I will be testing this out in the next few days! 😍 |
xenova
left a comment
xenova
left a comment
There was a problem hiding this comment.
Thanks for the PR! Good start 👍
| "esbuild": "^0.27.0", | ||
| "onnxruntime-node": "1.24.0-dev.20251104-75d35474d5", | ||
| "onnxruntime-web": "1.24.0-dev.20251104-75d35474d5", | ||
| "rimraf": "^6.1.2", |
| console.log(`\nBuilding ${regularFile}...`); | ||
| await esbuild({ | ||
| bundle: true, | ||
| treeShaking: true, | ||
| logLevel: "warning", | ||
| entryPoints: [path.join(rootDir, "src/transformers.js")], | ||
| platform, | ||
| format, | ||
| outfile: path.join(outdir, regularFile), | ||
| sourcemap: true, | ||
| external: externalModules, | ||
| plugins, | ||
| logOverride: { | ||
| // Suppress import.meta warning for CJS builds - it's handled gracefully in the code | ||
| "empty-import-meta": "silent", | ||
| }, | ||
| }); | ||
| reportSize(path.join(outdir, regularFile)); | ||
|
|
||
| console.log(`\nBuilding ${minFile}...`); | ||
| await esbuild({ | ||
| bundle: true, | ||
| treeShaking: true, | ||
| logLevel: "warning", | ||
| entryPoints: [path.join(rootDir, "src/transformers.js")], | ||
| platform, | ||
| format, | ||
| outfile: path.join(outdir, minFile), | ||
| sourcemap: true, | ||
| minify: true, | ||
| external: externalModules, | ||
| plugins, | ||
| legalComments: "none", | ||
| logOverride: { | ||
| // Suppress import.meta warning for CJS builds - it's handled gracefully in the code | ||
| "empty-import-meta": "silent", | ||
| }, | ||
| }); |
There was a problem hiding this comment.
minimize duplication by defining a list of defaults which we unpack unto each config.
|
|
||
| try { | ||
| console.log("=== CLEAN ==="); | ||
| execSync(`rimraf ${DIST_FOLDER}`, { stdio: "inherit" }); |
There was a problem hiding this comment.
if we are going to call rimraf using execSync, we might as well just use native fs functions to clear the dist directory. -1 dependency :)
| export const NODE_EXTERNAL_MODULES = [ | ||
| "onnxruntime-common", | ||
| "onnxruntime-node", | ||
| "sharp", | ||
| "node:fs", | ||
| "node:path", | ||
| "node:url", | ||
| ]; |
There was a problem hiding this comment.
the node:... list may grow in future. Is there a way to specify a pattern like /^node:.*/?
There was a problem hiding this comment.
(this may only be possible in the section of code where we use it)
| contents: ` | ||
| const noop = () => {}; | ||
| const emptyObj = {}; | ||
| export default emptyObj; | ||
| export const Readable = { fromWeb: noop }; | ||
| export const pipeline = noop; | ||
| export const createWriteStream = noop; | ||
| export const createReadStream = noop; | ||
| ` |
There was a problem hiding this comment.
Will this be added one, or for each module we will ignore? 👀
| const ORT_JSEP_FILE = 'ort-wasm-simd-threaded.jsep.mjs'; | ||
| const ORT_BUNDLE_FILE = 'ort.bundle.min.mjs'; |
There was a problem hiding this comment.
[WIP] How do we ensure this is bundled with the main library, enabling #1471
| } | ||
|
|
||
| console.log("=== CLEAN ==="); | ||
| execSync(`rimraf ${outdir}`, { stdio: "inherit" }); |
| logOverride: { | ||
| "empty-import-meta": "silent", | ||
| }, | ||
| }); |
There was a problem hiding this comment.
same comment as above RE: duplication.
Maybe we can also consolidate dev and build logic to reduce duplication
No description provided.