Skip to content

Adding custom 3d mask into ModernBert #38671

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

bvantuan
Copy link
Contributor

@bvantuan bvantuan commented Jun 8, 2025

What does this PR do?

Feature requested by #38040

Who can review?

Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.
@ArthurZucker

@bvantuan bvantuan marked this pull request as draft June 8, 2025 06:47
@bvantuan
Copy link
Contributor Author

bvantuan commented Jun 8, 2025

Update:
The custom 3D mask is supported only for eager and SDPA attention modes.
A test, test_model_3d_mask_shapes, has been added to verify the correctness of this feature.

@bvantuan bvantuan marked this pull request as ready for review June 8, 2025 07:54
@github-actions github-actions bot requested review from ArthurZucker and ydshieh June 8, 2025 07:55
@bvantuan
Copy link
Contributor Author

Cc @ArthurZucker ! Could you please review when convenient?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant