Correctly handle unbatched audio inputs in Gemma3nAudioFeatureExtractor #42076
+11
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thanks for sending this fix @kho! |
Contributor
|
cc @zucchini-nlp @Rocketknight1 for a review to help us land this for Gemma 3n. |
zucchini-nlp
reviewed
Nov 7, 2025
Comment on lines
308
to
314
| if is_batched: | ||
| raw_speech = [np.asarray([rs]).T for rs in raw_speech] | ||
| elif not is_batched and not isinstance(raw_speech, np.ndarray): | ||
| raw_speech = np.asarray(raw_speech) | ||
|
|
||
| if not is_batched: # always return a batch | ||
| raw_speech = [np.asarray([raw_speech])] | ||
| raw_speech = [np.asarray([raw_speech]).T] |
Member
There was a problem hiding this comment.
not very related to this PR, but let's unify a bit these blocks for easier reading, maybe smth like below. Otherwise LGTM
if not is_batched:
raw_speech = [np.asarray(raw_speech)]
raw_speech = [np.asarray([rs]).T for rs in raw_speech]
Contributor
Author
There was a problem hiding this comment.
Good point! I just realized that we also don't need the np.asarray() call in the if statement. PTAL and thanks for reviewing!
…AudioFeatureExtractor
Contributor
|
[For maintainers] Suggested jobs to run (before merge) run-slow: gemma3n |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
Abdennacer-Badaoui
pushed a commit
to Abdennacer-Badaoui/transformers
that referenced
this pull request
Nov 10, 2025
…or (huggingface#42076) * Correctly handle unbatched audio inputs in Gemma3nAudioFeatureExtractor * Simplify the logic for batching the unbatched speech input in Gemma3nAudioFeatureExtractor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Correctly handle unbatched audio inputs in Gemma3nAudioFeatureExtractor
Before submitting
Pull Request section?
to it if that's the case.
documentation guidelines, and
here are tips on formatting docstrings.
Who can review?
Anyone in the community is free to review the PR once the tests have passed. Feel free to tag
members/contributors who may be interested in your PR.