-
Notifications
You must be signed in to change notification settings - Fork 31.1k
[Bugfix] fix qwen3vl expand generation with video #42089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
[For maintainers] Suggested jobs to run (before merge) run-slow: qwen3_vl, qwen3_vl_moe |
| inputs = self.processor.apply_chat_template( | ||
| self.message3, tokenize=True, add_generation_prompt=True, return_dict=True, return_tensors="pt" | ||
| ).to(torch_device) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ig we need to do either beam search or sampling with num_return_sequences > 1 to tigger the needed behavior, no?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, the test uses num_beams=2 and num_return_sequences=2.
| output = model.generate(**inputs, max_new_tokens=30, do_sample=False, num_beams=2, num_return_sequences=2) |
|
run-slow: qwen3_vl_moe |
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
|
This comment contains models: ["models/qwen3_vl_moe"] |
CI Results✅ No failing test specific to this PR 🎉 ! |
What does this PR do?
fix qwen3vl expand generation with video
related issues: QwenLM/Qwen3-VL#1769, QwenLM/Qwen3-VL#1621
@zucchini-nlp
test script:
🫡 test pass with