Skip to content

Conversation

@Xqle
Copy link
Contributor

@Xqle Xqle commented Nov 8, 2025

What does this PR do?

As suggested in #42009 (comment), when return_metadata is in kwargs but set to False, metadata should be popped.

Before submitting

  • This PR fixes a typo or improves the docs (you can dismiss the other checks if that's the case).
  • Did you read the contributor guideline,
    Pull Request section?
  • Was this discussed/approved via a Github issue or the forum? Please add a link
    to it if that's the case.
  • Did you make sure to update the documentation with your changes? Here are the
    documentation guidelines, and
    here are tips on formatting docstrings.
  • Did you write any new necessary tests?

Who can review?

@zucchini-nlp @yonigozlan @molbap

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2025

[For maintainers] Suggested jobs to run (before merge)

run-slow: glm4v, qwen3_vl, smolvlm, video_llama_3

Copy link
Member

@zucchini-nlp zucchini-nlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@zucchini-nlp zucchini-nlp enabled auto-merge (squash) November 10, 2025 08:15
@zucchini-nlp zucchini-nlp merged commit f5630f9 into huggingface:main Nov 10, 2025
15 checks passed
@HuggingFaceDocBuilderDev

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

@Xqle Xqle deleted the fix-return-metadata-checking-logic branch November 10, 2025 08:30
Abdennacer-Badaoui pushed a commit to Abdennacer-Badaoui/transformers that referenced this pull request Nov 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants