Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify gdb.parameter("debug-file"directory") returns a string #1177

Merged
merged 1 commit into from
Mar 16, 2025

Conversation

hugsy
Copy link
Owner

@hugsy hugsy commented Mar 15, 2025

Description

This PR fixes a missing type check introduced by #1173 when getting result from gdb.parameter while setting debug-file-directory

Checklist

  • My code follows the code style of this project.
  • My change includes a change to the documentation, if required.
  • If my change adds new code, adequate tests have been added.
  • I have read and agree to the CONTRIBUTING document.

Signed-off-by: hugsy <crazy.hugsy@outlook.com>
Copy link

🤖 Coverage update for 31a31c1 🟢

Old New
Commit 265f22e 31a31c1
Score 71.0907% 71.0907% (0)

Copy link

🤖 Coverage update for 31a31c1 🔴

Old New
Commit 265f22e 31a31c1
Score 71.0907% 71.0826% (-0.0081)

@Grazfather Grazfather changed the title [Type Hint] Type validation Verify object returned from gdb.parameter is a string Mar 16, 2025
@Grazfather Grazfather changed the title Verify object returned from gdb.parameter is a string Verify gdb.parameter("debug-file"directory") returns a string Mar 16, 2025
@hugsy hugsy merged commit c631746 into main Mar 16, 2025
7 checks passed
@hugsy hugsy deleted the hugsy/pylance--fix branch March 16, 2025 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants