-
Notifications
You must be signed in to change notification settings - Fork 1
Add debug #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add debug #19
Conversation
unity
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
src/lib/rest-api.js
Outdated
| } | ||
|
|
||
| if( params.batch && process.env.NODE_ENV === "development" && process.env.DEBUG ) { | ||
| debug("perform:") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this just for cosmetic purposes ?
README says that having a FirehoseArray will not stop the API from being called.
| @@ -1,12 +1,18 @@ | |||
| # CHANGELOG | |||
|
|
|||
| ## 2.0.0-rc1 | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ouch, I caused some confusion here, the version 2.0.0 was already published and tagged in this repository. I should have put a separate entry in the changelog to make it clear, but since there were no changes comparing to beta.3 I forgot doing so. I will cleanup the situation.
No description provided.