Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/enforce code style #77

Open
wants to merge 8 commits into
base: release/v0.14.0
Choose a base branch
from
Open

Feature/enforce code style #77

wants to merge 8 commits into from

Conversation

unity
Copy link
Contributor

@unity unity commented Aug 10, 2018

  • applies eslint + prettier + flow on each commit,
  • prettifies the entire codebase
  • fixes a few minor Flow type errors
  • disables flow warnings

@unity
enforce code standards
9b27793 
- prettier
- lint
- flow

before commits.
@unity
lint && prettify
2e884c3 
and fix Flow `HullConnectorUpdateHandlerCallback` and `HullSegmentUpdateHandlerCallback` signatures to accept a second, ignored arguments
@unity
more style fixes
66afb86
@unity unity requested a review from michaloo August 10, 2018 20:19
@unity
Improve flow typing, and allow Generics, add new items to document
d3f406f 
BEWARE: `documentation` is broken because of the `...$Exact<>` type syntax -> disabled for this commit. Must be fixed.

```
{
  "type": "ObjectTypeSpreadProperty",
  "start": 2661,
  "end": 2694,
  "loc": {
    "start": {
      "line": 101,
      "column": 2
    },
    "end": {
      "line": 101,
      "column": 35
    }
  },
  "argument": {
    "type": "GenericTypeAnnotation",
    "start": 2664,
    "end": 2693,
    "loc": {
      "start": {
        "line": 101,
        "column": 5
      },
      "end": {
        "line": 101,
        "column": 34
      }
    },
    "typeParameters": {
      "type": "TypeParameterInstantiation",
      "start": 2670,
      "end": 2693,
      "loc": {
        "start": {
          "line": 101,
          "column": 11
        },
        "end": {
          "line": 101,
          "column": 34
        }
      },
      "params": [
        {
          "type": "GenericTypeAnnotation",
          "start": 2671,
          "end": 2692,
          "loc": {
            "start": {
              "line": 101,
              "column": 12
            },
            "end": {
              "line": 101,
              "column": 33
            }
          },
          "typeParameters": null,
          "id": {
            "type": "Identifier",
            "start": 2671,
            "end": 2692,
            "loc": {
              "start": {
                "line": 101,
                "column": 12
              },
              "end": {
                "line": 101,
                "column": 33
              },
              "identifierName": "HullContextWithClient"
            },
            "name": "HullContextWithClient"
          }
        }
      ]
    },
    "id": {
      "type": "Identifier",
      "start": 2664,
      "end": 2670,
      "loc": {
        "start": {
          "line": 101,
          "column": 5
        },
        "end": {
          "line": 101,
          "column": 11
        },
        "identifierName": "$Exact"
      },
      "name": "$Exact"
    }
  }
}
TypeError: Cannot read property 'name' of undefined
    at [...]/documentation/lib/infer/properties.js:46:62
    at Array.forEach (<anonymous>)
    at inferProperties ([...]/documentation/lib/infer/properties.js:44:24)
    at Array.inferProperties ([...]/documentation/lib/infer/properties.js:61:7)
    at comment ([...]/documentation/lib/index.js:39:25)
    at Array.map (<anonymous>)
    at [...]/documentation/lib/index.js:95:48
    at arrayMap ([...]/documentation/node_modules/lodash/lodash.js:631:23)
    at map ([...]/documentation/node_modules/lodash/lodash.js:9546:14)
    at Function.flatMap ([...]/documentation/node_modules/lodash/lodash.js:9249:26)

```
@unity
wip
09c82fe
@unity
use mocha.opts
4b65f20
@unity
tests pass (even though some are disabled)
8aa491f 
Checkout instances of TODO in repo
@unity
wip yarn start [connector]
7c5ad7a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaloo michaloo Awaiting requested review from michaloo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@unity