Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First draft completed - cancer-screening #31

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Conversation

CatReid
Copy link
Collaborator

@CatReid CatReid commented Jan 8, 2025

First draft completed - cancer-screening, styled and rendered.

Converted from HB to LA.

First draft completed - cancer-screening, styled and rendered.

Converted from HB to LA.
@CatReid CatReid requested a review from MikeJohnPage January 8, 2025 16:29
Comment on lines +72 to +74
select(
-trust18_name, -cervical_screening_percentage, -breast_screening_percentage, -bowel_screening_percentage
) |>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A more succinct way to write this would be to just select() the two columns you need, then you don't need to use relocate():

cancer_screening_hb |>
  left_join(hb_lookup) |>
  select(trust18_code, total_cancer_screening_percentage)

Would achieve the same thing :)

@MikeJohnPage
Copy link
Member

Really great stuff @CatReid!

@MikeJohnPage
Copy link
Member

Do England include both cancer and cancer screening? I imagine these two are correlated.

@MikeJohnPage MikeJohnPage merged commit 488584b into main Jan 20, 2025
@MikeJohnPage MikeJohnPage deleted the cancer-screening branch January 20, 2025 16:55
@CatReid
Copy link
Collaborator Author

CatReid commented Jan 20, 2025

@MikeJohnPage yes they do! they're 2 separate indicators in England's HI - screening is under lives and cancer is under people. And thank you for the tip!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants