Skip to content

Improve testing #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
billdenney merged 3 commits into from
Feb 25, 2025
Merged

Improve testing #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b297860
Improve testing
billdenney Feb 25, 2025
2c52199
Improve testing
billdenney Feb 25, 2025
4dbe0bc
Improve testing
billdenney Feb 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NAMESPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ S3method(format,tab_list)
S3method(knit_print,tab_list)
S3method(knit_print,tab_tibble)
S3method(print,tab_list)
S3method(vctrs::vec_ptype_abbr,tab_list)
export(knit_print)
export(new_tab_list)
export(new_tab_tibble)
Expand Down
3 changes: 2 additions & 1 deletion R/objects.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,9 @@ new_tab_list <- function(x) {
vctrs::new_vctr(x, class = "tab_list")
}

#' @exportS3Method vctrs::vec_ptype_abbr
vec_ptype_abbr.tab_list <- function(x, ...) {
"tablist"
"tab_list"
}

#' @export
Expand Down
2 changes: 1 addition & 1 deletion tests/testthat/test-knit_print.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ test_that("knit_print.tab_tibble (and implicitly knit_print.tab_list and print_t
) |>
new_tab_tibble()
expect_output(
knit_print(d_tab),
suppressWarnings(knit_print(d_tab)),
regexp = "Cars with 8 cylinders"
)
expect_output(
Expand Down
Loading