Pod Disruption Budget implementation #900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
triceras
force-pushed
the
rafael/PodDisruptionBugdet
branch
from
a1c32e5 to
1eb8ab0
Compare
…ogging. A few code refactors
triceras
force-pushed
the
rafael/PodDisruptionBugdet
branch
from
7781b69 to
3628864
Compare
…eOrUpdate from the controller runtime
… pods on the same node pool
SaaldjorMike
reviewed
Feb 5, 2025
SaaldjorMike
approved these changes
Feb 5, 2025
Removed unused label variable Co-authored-by: Mike Rostermund <mike.rostermund@crowdstrike.com>
Removed unused input (hnp *HumioNodePool) from createOrUpdatePDB
triceras
added a commit
that referenced
this pull request
Mar 12, 2025
* Rebasing * API docs for PDB * Removed unnused variables * Removed unused function * Rebasing * fixes * Removed func podLabelsForHumio * Improvements * Removed unused function cleanupOrphanedNodePoolPDBs * Removed comments in the controller pdb functions * HumioNodeSpec * HumioNodeSpec updates * updated api docs for pdb * using pdb functions * removed func ensurePodDisruptionBudgets * Moved cleanupOrphanedPDBs outside the foor loop in cleanupUnusedResources * fixed wrong function placement * Adding missing func ensureViewGroupPermissionsConfigMap back to the reconcile loop * remove obsolete func shouldCreatePDBForNodePool * Update humiocluster_controller.go * Update humiocluster_controller_test.go * Update humiocluster_types.go * Update humiocluster_controller.go * PDB improvements * Added API docs * Fixed integer overflow conversion * Using handlePDBFinalizers * Remobed PDB logic from ensureMismatchedPodsAreDeleted. Improved PDB logging. A few code refactors * removed unused funcs cleanupOrphanedPDBs, isValidNodePool and isOwnedByCluster * Rebasing * Simplified the logic in createOrUpdatePDB to use controllerutil.CreateOrUpdate from the controller runtime * Created helper function MatchingLabelsForHumioNodePool for targetting pods on the same node pool * Update controllers/humiocluster_controller.go Removed unused label variable Co-authored-by: Mike Rostermund <mike.rostermund@crowdstrike.com> * Update humiocluster_controller.go Removed unused input (hnp *HumioNodePool) from createOrUpdatePDB --------- Co-authored-by: Mike Rostermund <mike.rostermund@crowdstrike.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a new implementation for Pod Disruption Burget. This implements #104