Skip to content

Pod Disruption Budget implementation #900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Feb 5, 2025
Merged

Conversation

triceras
Copy link
Contributor

This is a new implementation for Pod Disruption Burget. This implements #104

@triceras triceras marked this pull request as ready for review January 14, 2025 04:40
@triceras triceras requested a review from a team as a code owner January 14, 2025 04:40
@triceras triceras force-pushed the rafael/PodDisruptionBugdet branch from a1c32e5 to 1eb8ab0 Compare January 16, 2025 04:50
@triceras triceras requested a review from SaaldjorMike January 17, 2025 04:05
@triceras triceras requested a review from SaaldjorMike January 28, 2025 04:23
@triceras triceras force-pushed the rafael/PodDisruptionBugdet branch from 7781b69 to 3628864 Compare February 3, 2025 00:53
triceras and others added 3 commits February 5, 2025 20:53
Removed unused label variable

Co-authored-by: Mike Rostermund <mike.rostermund@crowdstrike.com>
Removed unused input (hnp *HumioNodePool) from createOrUpdatePDB
@triceras triceras merged commit 8966f46 into master Feb 5, 2025
29 checks passed
@triceras triceras deleted the rafael/PodDisruptionBugdet branch February 5, 2025 22:41
triceras added a commit that referenced this pull request Mar 12, 2025
* Rebasing

* API docs for PDB

* Removed unnused variables

* Removed unused function

* Rebasing

* fixes

* Removed func podLabelsForHumio

* Improvements

* Removed unused function cleanupOrphanedNodePoolPDBs

* Removed comments in the controller pdb functions

* HumioNodeSpec

* HumioNodeSpec updates

* updated api docs for pdb

* using pdb functions

* removed func ensurePodDisruptionBudgets

* Moved cleanupOrphanedPDBs outside the foor loop in cleanupUnusedResources

* fixed wrong function placement

* Adding missing func ensureViewGroupPermissionsConfigMap back to the reconcile loop

* remove obsolete func shouldCreatePDBForNodePool

* Update humiocluster_controller.go

* Update humiocluster_controller_test.go

* Update humiocluster_types.go

* Update humiocluster_controller.go

* PDB improvements

* Added API docs

* Fixed integer overflow conversion

* Using handlePDBFinalizers

* Remobed PDB logic from ensureMismatchedPodsAreDeleted. Improved PDB logging. A few code refactors

* removed unused funcs cleanupOrphanedPDBs, isValidNodePool and isOwnedByCluster

* Rebasing

* Simplified the logic in createOrUpdatePDB to use controllerutil.CreateOrUpdate from the controller runtime

* Created helper function MatchingLabelsForHumioNodePool for targetting pods on the same node pool

* Update controllers/humiocluster_controller.go

Removed unused label variable

Co-authored-by: Mike Rostermund <mike.rostermund@crowdstrike.com>

* Update humiocluster_controller.go

Removed unused input (hnp *HumioNodePool) from createOrUpdatePDB

---------

Co-authored-by: Mike Rostermund <mike.rostermund@crowdstrike.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants