-
Notifications
You must be signed in to change notification settings - Fork 33
Seamless operator upgrades #967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jswoods
merged 8 commits into
master
from
jestin/seamless-operator-upgrades-split-annotations
May 13, 2025
Merged
Seamless operator upgrades #967
jswoods
merged 8 commits into
master
from
jestin/seamless-operator-upgrades-split-annotations
May 13, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07d366e
to
b74a669
Compare
snigdhasaikam1
approved these changes
May 7, 2025
SaaldjorMike
reviewed
May 9, 2025
…hing of the base humiocluster and values files
…some clarification around the purpose of evaluating them
d41bd5f
to
bd03ec8
Compare
SaaldjorMike
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for seamless operator upgrades by:
Note that some exceptions exist, which include the main humio version (due to the upgrade logic) as well as some resources that do not typically change, such as default requests/limits, etc. Adding support for these is simple and can be done in this change if we'd like, or we can instead track these only when the time comes where we need to update them.
By far, most of the cause for the humio pod restarts occur when the helper image changes, and this is supported as a managed field as well as any environment variables that are added by the operator as defaults.
Also added helm upgrade tests which by using the new
HUMIO_OPERATOR_DEFAULT_HUMIO_HELPER_IMAGE_MANAGED
in the test will capture what happens when the operator helper image default changes. This way the test can be run against the current version of the code rather than only against older versions which are "upgraded" to the current. Tests for both are included but we may chose to remove the upgrade-from-an-older-version test for maintainability.Fixes #246.