Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/token list migration #155

Closed

Conversation

vic-en
Copy link
Collaborator

@vic-en vic-en commented Jul 12, 2023

Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved title ("feat/", "fix/", "docs/", "refactor/")

A description of the changes proposed in the pull request:
Copies token lists over from template directory to the conf directory.
PR for #148

Tests performed by the developer:

  • Manual test

Tips for QA testing:

  • Run usual yarn commands to setup gateway.
  • At yarn build the token files should be copied over.

gateway-setup.sh Outdated Show resolved Hide resolved
@rapcmia rapcmia requested review from rapcmia and nikspz July 13, 2023 05:02
@rapcmia
Copy link
Contributor

rapcmia commented Jul 13, 2023

PR update:

  • Test latest commit 5631e235
  • Test on local mbp(m1) and Ubuntu22.04 server
  • Test this PR and latest development client branch

Run yarn && yarn build and observed:
image

  • This does not seem to copy anything to the conf/list even we change the permission sudo chmod 777 conf/list and re-run yarn build for both local and cloud

Test on local mbp(m1)
image

  • Observed that it was only able to copy these lists/*.json files from templates/lists when we ran gateway-setup.sh

Test on Ubuntu22.04 cloud server

Copy link
Contributor

@fengtality fengtality left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See other PR

@@ -16,6 +16,7 @@
"dev:debug": "NODE_ENV=dev DEBUG=* nodemon src/index.ts",
"start": "/bin/bash ./startup.sh",
"copy-files": "copyfiles -a 'src/**/schema/*.json' 'src/templates/*.yml' 'src/templates/lists/*.json' 'test/services/data/**/*.*' dist",
"copy-files:token-list": "mkdir -p conf/lists && copyfiles -u 'src/templates/lists/*.json' conf/lists",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this works if you change -u to -f here

@fengtality fengtality mentioned this pull request Jul 14, 2023
2 tasks
@nikspz nikspz closed this Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants