commit 14

.github/workflows/deployment.yml

@@ -7,19 +7,23 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v2
-      - run: |
-          sudo curl -o /usr/bin/framgia-ci https://raw.githubusercontent.com/framgia/ci-report-tool/master/dist/framgia-ci
-          sudo chmod +x /usr/bin/framgia-ci
-          sudo apt install python3-pip
-          sudo apt install libcurl4-openssl-dev libssl-dev
-          sudo apt-get install -y python3-setuptools
-      - run: |
-          yes | pip3 install wheel
-          pip3 install framgia-ci
-          pip3 uninstall --yes cleo clikit
-          yes | pip3 install cleo==0.6.8
-      - name: Run CI
+      - run: sudo gem install bundler:1.17.2
+      - uses: actions/cache@v2
+        with:
+          path: api/vendor/bundle
+          key: ${{ runner.os }}-gems-${{ hashFiles('**/Gemfile.lock') }}
+          restore-keys: |
+            ${{ runner.os }}-gems-
+      - name: Install gemfilee
         run: |
           cd api
-          ls -la && pwd
-          framgia-ci run --local
+          bundle config path vendor/bundle
+          bundle install
+      - name: Rubocop
+        run: cd api && bundle exec rubocop -c .rubocop.yml
+      - name: Rails Best Practices
+        run: cd api && bundle exec rails_best_practices -e "db/schema.rb,db/migrate,vendor,app/models/application_record.rb"
+      - name: Rpec
+        run: cd api && bundle exec rspec --format documentation
+      - name: reek
+        run: cd api && bundle exec reek

api/.rspec

@@ -1,2 +1 @@
---color
 --require spec_helper

api/.rubocop.yml

@@ -13,24 +13,25 @@ inherit_from:
 AllCops:
   # Include gemspec and Rakefile
   Include:
-    - 'app/**/*'
-    - 'lib/**/*'
-    - '**/*.gemspec'
-    - 'Gemfile'
+    - "app/**/*"
+    - "lib/**/*"
+    - "**/*.gemspec"
+    - "Gemfile"
   Exclude:
-    - 'vendor/**/*'
-    - 'config/unicorn.rb'
-    - 'bin/*'
-    - 'db/**/*'
-    - 'spec/**/*'
-    - 'script/rails'
-    - 'config/**/*'
-    - 'app/views/**/*'
-    - 'app/assets/**/*'
-    - 'app/javascript/**/*'
-    - '.idea/**/*'
-    - '**/.DS_Store'
-    - '**/.keep'
+    - "vendor/**/*"
+    - "api/vendor/**/*"
+    - "config/unicorn.rb"
+    - "bin/*"
+    - "db/**/*"
+    - "spec/**/*"
+    - "script/rails"
+    - "config/**/*"
+    - "app/views/**/*"
+    - "app/assets/**/*"
+    - "app/javascript/**/*"
+    - ".idea/**/*"
+    - "**/.DS_Store"
+    - "**/.keep"
 
 # Indent private/protected/public as deep as method definitions
 Layout/AccessModifierIndentation:
@@ -40,7 +41,7 @@ Layout/AccessModifierIndentation:
     - indent
 
 # Align the elements of a hash literal if they span more than one line.
-Layout/AlignHash:
+Layout/HashAlignment:
   # Alignment of entries using hash rocket as separator. Valid values are:
   #
   # key - left alignment of keys
@@ -103,7 +104,7 @@ Layout/AlignHash:
     - ignore_implicit
     - ignore_explicit
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   # Alignment of parameters in multi-line method calls.
   #
   # The `with_first_parameter` style aligns the following lines along the same column
@@ -130,12 +131,6 @@ Metrics/AbcSize:
   # a Float.
   Max: 20
 
-Style/BracesAroundHashParameters:
-  EnforcedStyle: no_braces
-  SupportedStyles:
-    - braces
-    - no_braces
-
 # Indentation of `when`.
 Layout/CaseIndentation:
   EnforcedStyle: case
@@ -172,7 +167,7 @@ Style/ClassCheck:
     - kind_of?
 
 Metrics/ClassLength:
-  CountComments: false  # count full line comments?
+  CountComments: false # count full line comments?
   Max: 100
 
 # Align with the style guide.
@@ -184,11 +179,11 @@ Style/CollectionMethods:
   #   PreferredMethods:
   #     find: detect
   PreferredMethods:
-    collect: 'map'
-    collect!: 'map!'
-    inject: 'reduce'
-    detect: 'find'
-    find_all: 'select'
+    collect: "map"
+    collect!: "map!"
+    inject: "reduce"
+    detect: "find"
+    find_all: "select"
 
 # Checks formatting of special comments
 Style/CommentAnnotation:
@@ -233,9 +228,9 @@ Layout/EmptyLinesAroundModuleBody:
 
 Naming/FileName:
   Exclude:
-    - '**/Rakefile'
-    - '**/Gemfile'
-    - '**/Capfile'
+    - "**/Rakefile"
+    - "**/Gemfile"
+    - "**/Capfile"
 
 # Checks use of for or each in multiline loops.
 Style/For:
@@ -268,7 +263,7 @@ Style/HashSyntax:
     - hash_rockets
 
 # Checks the indentation of the first key in a hash literal.
-Layout/IndentFirstHashElement:
+Layout/FirstHashElementIndentation:
   # The value `special_inside_parentheses` means that hash literals with braces
   # that have their opening brace on the same line as a surrounding opening
   # round parenthesis, shall have their first key indented relative to the
@@ -287,13 +282,12 @@ Style/LambdaCall:
     - call
     - braces
 
-Metrics/LineLength:
-  Max: 80
+Layout/LineLength:
+  Max: 120
   AllowURI: true
   Exclude:
     - config/routes.rb
 
-
 Style/Next:
   # With `always` all conditions at the end of an iteration needs to be
   # replace by next - with `skip_modifier_ifs` the modifier if like this one
@@ -319,7 +313,7 @@ Style/MethodDefParentheses:
     - require_no_parentheses
 
 Metrics/MethodLength:
-  CountComments: false  # count full line comments?
+  CountComments: false # count full line comments?
   Max: 10
 
 Naming/MethodName:
@@ -341,18 +335,18 @@ Style/ParenthesesAroundCondition:
 
 Style/PercentLiteralDelimiters:
   PreferredDelimiters:
-    '%':  ()
-    '%i': ()
-    '%q': ()
-    '%Q': ()
-    '%r': '{}'
-    '%s': ()
-    '%w': ()
-    '%W': ()
-    '%x': ()
+    "%": ()
+    "%i": ()
+    "%q": ()
+    "%Q": ()
+    "%r": "{}"
+    "%s": ()
+    "%w": ()
+    "%W": ()
+    "%x": ()
 
 Naming/PredicateName:
-  NamePrefixBlacklist:
+  ForbiddenPrefixes:
     - get_
 
 Style/RaiseArgs:
@@ -361,7 +355,6 @@ Style/RaiseArgs:
     - compact # raise Exception.new(msg)
     - exploded # raise Exception, msg
 
-
 Style/RedundantReturn:
   # When true allows code like `return x, y`.
   AllowMultipleReturnValues: false
@@ -382,7 +375,6 @@ Style/SignalException:
     - only_fail
     - semantic
 
-
 Style/SingleLineBlockParams:
   Methods:
     - reduce:
@@ -430,7 +422,7 @@ Layout/SpaceInsideHashLiteralBraces:
     - space
     - no_space
 
-Layout/TrailingBlankLines:
+Layout/TrailingEmptyLines:
   EnforcedStyle: final_newline
   SupportedStyles:
     - final_newline
@@ -483,7 +475,7 @@ Style/TrivialAccessors:
   #
   # Commonly used in DSLs
   AllowDSLWriters: false
-  Whitelist:
+  AllowedMethods:
     - to_ary
     - to_a
     - to_c

api/.rubocop_disabled.yml

@@ -2,8 +2,8 @@
 
 Style/FrozenStringLiteralComment:
   Description: >-
-                 Add the frozen_string_literal comment to the top of files
-                 to help transition from Ruby 2.3.0 to Ruby 3.0.
+    Add the frozen_string_literal comment to the top of files
+    to help transition from Ruby 2.3.0 to Ruby 3.0.
   Enabled: false
 
 Style/InlineComment:
@@ -50,13 +50,13 @@ Metrics/CyclomaticComplexity:
   Description: "Avoid complex methods."
   Enabled: false
 
-Layout/AlignArray:
+Layout/ArrayAlignment:
   Description: >-
-                 Align the elements of an array literal if they span more than
-                 one line.
+    Align the elements of an array literal if they span more than
+    one line.
   Enabled: false
 
-Style/UnneededPercentQ:
+Style/RedundantPercentQ:
   Description: "Checks for %q/%Q when single quotes or double quotes would do."
   Enabled: false