Merge branch 'main' into redesign-docs-v2

huntabyte · Dec 1, 2023 · 4f901c5 · 4f901c5
2 parents 8349969 + bbf7e4a
commit 4f901c5
Show file tree

Hide file tree

Showing 4 changed files with 12 additions and 4 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @huntabyte/primitives
 
+## 0.9.9
+
+### Patch Changes
+
+- fix: bug where menu `onChange` functions were being called before change ([#191](https://github.com/huntabyte/bits-ui/pull/191))
+
 ## 0.9.8
 
 ### Patch Changes

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "bits-ui",
-	"version": "0.9.8",
+	"version": "0.9.9",
 	"license": "MIT",
 	"repository": "github:huntabyte/bits-ui",
 	"scripts": {

diff --git a/src/lib/bits/menu/components/menu-checkbox-item.svelte b/src/lib/bits/menu/components/menu-checkbox-item.svelte
@@ -20,8 +20,10 @@
 		disabled,
 		defaultChecked: checked,
 		onCheckedChange: ({ next }) => {
-			onCheckedChange?.(next);
-			checked = next;
+			if (checked !== next) {
+				onCheckedChange?.(next);
+				checked = next;
+			}
 			return next;
 		}
 	});

diff --git a/src/lib/bits/menu/components/menu-radio-group.svelte b/src/lib/bits/menu/components/menu-radio-group.svelte
@@ -15,7 +15,7 @@
 	} = setRadioGroupCtx({
 		defaultValue: value,
 		onValueChange: ({ next }) => {
-			if (next) {
+			if (next && next !== value) {
 				onValueChange?.(next);
 				value = next;
 			}