Merge pull request #10 from huntabyte/fix/button-role

huntabyte · Aug 8, 2023 · 75742cd · 75742cd
2 parents 4692b9b + 8219393
commit 75742cd
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.changeset/fair-laws-flow.md b/.changeset/fair-laws-flow.md
@@ -0,0 +1,5 @@
+---
+"@huntabyte/primitives": patch
+---
+
+[Button] Remove default role
diff --git a/src/lib/primitives/button/components/Button.svelte b/src/lib/primitives/button/components/Button.svelte
@@ -9,6 +9,7 @@
 </script>
 
 {#if builders && builders.length}
+	<!-- svelte-ignore a11y-no-static-element-interactions -->
 	<svelte:element
 		this={href ? "a" : "button"}
 		type={href ? undefined : type}
@@ -19,7 +20,6 @@
 		on:keyup
 		on:mouseenter
 		on:mouseleave
-		role="button"
 		tabindex="0"
 		use:builderActions={{ builders }}
 		{...getAttrs(builders)}
@@ -28,6 +28,7 @@
 		<slot />
 	</svelte:element>
 {:else}
+	<!-- svelte-ignore a11y-no-static-element-interactions -->
 	<svelte:element
 		this={href ? "a" : "button"}
 		type={href ? undefined : type}
@@ -38,7 +39,6 @@
 		on:keyup
 		on:mouseenter
 		on:mouseleave
-		role="button"
 		tabindex="0"
 		{...$$restProps}
 	>