next: fix command click event handling (#816)

huntabyte · Oct 26, 2024 · 7a9ea27 · 7a9ea27
1 parent a7b094b
commit 7a9ea27
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 13 deletions.
diff --git a/.changeset/lovely-bags-allow.md b/.changeset/lovely-bags-allow.md
@@ -0,0 +1,5 @@
+---
+"bits-ui": patch
+---
+
+fix: command click events
diff --git a/packages/bits-ui/src/lib/bits/command/command.svelte.ts b/packages/bits-ui/src/lib/bits/command/command.svelte.ts
@@ -298,7 +298,7 @@ class CommandRootState {
 			const grandparent = item.parentElement?.parentElement;
 			if (!grandparent) return;
 			const firstChildOfParent = getFirstNonCommentChild(grandparent) as HTMLElement | null;
-			if (firstChildOfParent && firstChildOfParent.dataset.value === item.dataset.value) {
+			if (firstChildOfParent && firstChildOfParent.dataset?.value === item.dataset?.value) {
 				item
 					?.closest(GROUP_SELECTOR)
 					?.querySelector(GROUP_HEADING_SELECTOR)
@@ -877,20 +877,11 @@ class CommandItemState {
 		this.#select();
 	};
 
-	#onpointerdown = (e: PointerEvent) => {
+	#onclick = () => {
 		if (this.#disabled.current) return;
-		if (e.pointerType === "touch" || e.button !== 0) return e.preventDefault();
 		this.#onSelect();
 	};
 
-	#onpointerup = (e: PointerEvent) => {
-		if (this.#disabled.current) return;
-		if (e.pointerType === "touch") {
-			e.preventDefault();
-			this.#onSelect();
-		}
-	};
-
 	props = $derived.by(
 		() =>
 			({
@@ -901,9 +892,8 @@ class CommandItemState {
 				"data-selected": getDataSelected(this.isSelected),
 				[ITEM_ATTR]: "",
 				role: "option",
-				onpointerdown: this.#onpointerdown,
 				onpointermove: this.#onpointermove,
-				onpointerup: this.#onpointerup,
+				onclick: this.#onclick,
 			}) as const
 	);
 }