fix select multiple

huntabyte · Dec 2, 2023 · 9659611 · 9659611
1 parent 695721f
commit 9659611
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 5 deletions.
diff --git a/src/components/demos/select-demo.svelte b/src/components/demos/select-demo.svelte
@@ -13,7 +13,7 @@
 
 <Select.Root>
 	<Select.Trigger
-		class="inline-flex h-input w-[296px] items-center rounded-9px border border-border-input bg-background px-[11px] text-sm transition-colors placeholder:text-foreground-alt/50  focus:outline-none focus:ring-2 focus:ring-foreground focus:ring-offset-2 focus:ring-offset-background "
+		class="inline-flex h-input w-[296px] items-center rounded-9px border border-border-input bg-background px-[11px] text-sm transition-colors placeholder:text-foreground-alt/50  focus:outline-none focus:ring-2 focus:ring-foreground focus:ring-offset-2 focus:ring-offset-background"
 		aria-label="Select a theme"
 	>
 		<Palette class="mr-[9px] text-muted-foreground sq-6" />

diff --git a/src/lib/bits/select/components/select.svelte b/src/lib/bits/select/components/select.svelte
@@ -47,12 +47,16 @@
 		name,
 		multiple: multiple as Multiple,
 		forceVisible: true,
-		defaultSelected: selected,
+		defaultSelected: Array.isArray(selected)
+			? ([...selected] as $$Props["selected"])
+			: selected,
 		defaultOpen: open,
 		onSelectedChange: ({ next }) => {
 			if (Array.isArray(next)) {
-				onSelectedChange?.(next);
-				selected = next;
+				if (JSON.stringify(next) !== JSON.stringify(selected)) {
+					onSelectedChange?.(next);
+					selected = next;
+				}
 				return next;
 			}
 
@@ -82,7 +86,12 @@
 	);
 
 	$: open !== undefined && localOpen.set(open);
-	$: selected !== undefined && localSelected.set(selected);
+	$: selected !== undefined &&
+		localSelected.set(
+			Array.isArray(selected)
+				? ([...selected] as $$Props["selected"])
+				: selected
+		);
 
 	$: updateOption("required", required);
 	$: updateOption("disabled", disabled);