fix(next): preventScroll to true by default on context-menu (#709)

Co-authored-by: Davis SHYAKA <87414827+davis-shyaka@users.noreply.github.com> Co-authored-by: Hunter Johnston <64506580+huntabyte@users.noreply.github.com>
huntabyte · Oct 1, 2024 · 97bd443 · 97bd443
1 parent 27ad54c
commit 97bd443
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 0 deletions.
diff --git a/.changeset/many-pandas-fly.md b/.changeset/many-pandas-fly.md
@@ -0,0 +1,5 @@
+---
+"bits-ui": patch
+---
+
+set `preventScroll` to  `true` by default on `ContextMenu`
diff --git a/packages/bits-ui/src/lib/bits/context-menu/components/context-menu-content-static.svelte b/packages/bits-ui/src/lib/bits/context-menu/components/context-menu-content-static.svelte
@@ -17,6 +17,7 @@
 		ref = $bindable(null),
 		loop = true,
 		onInteractOutside = noop,
+		preventScroll = true,
 		// we need to explicitly pass this prop to the PopperLayer to override
 		// the default menu behavior of handling outside interactions on the trigger
 		onEscapeKeydown = noop,
@@ -55,6 +56,7 @@
 	{...mergedProps}
 	present={contentState.parentMenu.open.current || forceMount}
 	onInteractOutsideStart={handleInteractOutsideStart}
+	{preventScroll}
 	onInteractOutside={(e) => {
 		onInteractOutside(e);
 		if (e.defaultPrevented) return;

diff --git a/packages/bits-ui/src/lib/bits/context-menu/components/context-menu-content.svelte b/packages/bits-ui/src/lib/bits/context-menu/components/context-menu-content.svelte
@@ -18,6 +18,7 @@
 		ref = $bindable(null),
 		loop = true,
 		onInteractOutside = noop,
+		preventScroll = true,
 		// we need to explicitly pass this prop to the PopperLayer to override
 		// the default menu behavior of handling outside interactions on the trigger
 		onEscapeKeydown = noop,
@@ -57,6 +58,7 @@
 	sideOffset={2}
 	align="start"
 	present={contentState.parentMenu.open.current || forceMount}
+	{preventScroll}
 	onInteractOutsideStart={handleInteractOutsideStart}
 	onInteractOutside={(e) => {
 		onInteractOutside(e);