Add click event listener type to Menubar.Item Events (#89)

huntabyte · Aug 26, 2023 · f4dbdc5 · f4dbdc5
1 parent 2f281dd
commit f4dbdc5
Show file tree

Hide file tree

Showing 7 changed files with 1,524 additions and 1,585 deletions.
diff --git a/.changeset/rich-brooms-hammer.md b/.changeset/rich-brooms-hammer.md
@@ -0,0 +1,5 @@
+---
+"bits-ui": patch
+---
+
+Add `click` event listener type to `Menubar.Item` Events
diff --git a/src/app.html b/src/app.html
@@ -1,17 +1,16 @@
 <!DOCTYPE html>
 <html lang="en">
+	<head>
+		<meta charset="utf-8" />
+		<link rel="icon" href="%sveltekit.assets%/favicon.png" />
+		<meta name="viewport" content="width=device-width, initial-scale=1" />
+		%sveltekit.head%
+	</head>
 
-<head>
-	<meta charset="utf-8" />
-	<link rel="icon" href="%sveltekit.assets%/favicon.png" />
-	<meta name="viewport" content="width=device-width, initial-scale=1" />
-	%sveltekit.head%
-</head>
-
-<body data-sveltekit-preload-data="hover" class="bg-background antialiased font-sans overflow-y-scroll">
-	<div>
-		%sveltekit.body%
-	</div>
-</body>
-
-</html>
+	<body
+		data-sveltekit-preload-data="hover"
+		class="bg-background antialiased font-sans overflow-y-scroll"
+	>
+		<div>%sveltekit.body%</div>
+	</body>
+</html>
diff --git a/src/components/ui/badge/index.ts b/src/components/ui/badge/index.ts
@@ -5,10 +5,8 @@ export const badgeVariants = tv({
 	base: "inline-flex items-center rounded-md border px-2.5 py-0.5 text-xs font-semibold transition-colors focus:outline-none focus:ring-2 focus:ring-ring focus:ring-offset-2",
 	variants: {
 		variant: {
-			default:
-				"border-transparent bg-primary text-primary-foreground shadow hover:bg-primary/80",
-			secondary:
-				"border-transparent bg-secondary text-secondary-foreground hover:bg-secondary/80",
+			default: "border-transparent bg-primary text-primary-foreground shadow hover:bg-primary/80",
+			secondary: "border-transparent bg-secondary text-secondary-foreground hover:bg-secondary/80",
 			destructive:
 				"border-transparent bg-destructive text-destructive-foreground shadow hover:bg-destructive/80",
 			outline: "text-foreground"

diff --git a/src/components/ui/form/form-message.svelte b/src/components/ui/form/form-message.svelte
@@ -9,10 +9,7 @@
 </script>
 
 {#if $errors}
-	<p
-		class={cn("text-[0.8rem] font-medium text-destructive", className)}
-		id={formMessageId}
-	>
+	<p class={cn("text-[0.8rem] font-medium text-destructive", className)} id={formMessageId}>
 		{$errors}
 	</p>
 {/if}
diff --git a/src/lib/bits/menubar/types.ts b/src/lib/bits/menubar/types.ts
@@ -106,6 +106,7 @@ type ArrowProps = Expand<
 	HTMLDivAttributes;
 
 type ItemEvents<T extends Element = HTMLDivElement> = {
+	click: CustomEventHandler<PointerEvent, T>;
 	focusin: CustomEventHandler<FocusEvent, T>;
 	focusout: CustomEventHandler<FocusEvent, T>;
 	keydown: CustomEventHandler<KeyboardEvent, T>;
@@ -115,9 +116,7 @@ type ItemEvents<T extends Element = HTMLDivElement> = {
 };
 
 type SubTriggerEvents<T extends Element = HTMLDivElement> = Expand<
-	Omit<ItemEvents<T>, "pointerdown"> & {
-		click: CustomEventHandler<MouseEvent, T>;
-	}
+	Omit<ItemEvents<T>, "pointerdown">
 >;
 
 type CheckboxItemEvents = ItemEvents;