Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: compatibility with exactOptionalPropertyTypes #621

Merged
merged 5 commits into from
Jul 28, 2024

Conversation

Stadly
Copy link
Contributor

@Stadly Stadly commented Jul 27, 2024

With exactOptionalPropertyTypes enabled, optional properties cannot be undefined unless explicitly allowed. This commit explicitly allowes optional properties to be undefined.

Fixes #516.
Supersedes #517.

With [`exactOptionalPropertyTypes`](https://www.typescriptlang.org/tsconfig/#exactOptionalPropertyTypes) enabled, optional properties cannot be `undefined` unless explicitly allowed. This commit explicitly allowes optional properties to be `undefined`.
Copy link

changeset-bot bot commented Jul 27, 2024

🦋 Changeset detected

Latest commit: e0aad5c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
bits-ui Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Jul 27, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
bits-ui ✅ Ready (View Log) Visit Preview e0aad5c

Copy link
Owner

@huntabyte huntabyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@AdrianGonz97 AdrianGonz97 merged commit 8d649fa into huntabyte:main Jul 28, 2024
5 checks passed
@github-actions github-actions bot mentioned this pull request Jul 28, 2024
@Stadly Stadly deleted the exact-optional-property-types branch July 31, 2024 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Type errors when using exactOptionalPropertyTypes
3 participants