Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken links due to directory renaming from apps/www/** to sites/docs/** #1204

Closed
GeoGeorgeous opened this issue Jul 23, 2024 · 2 comments
Closed
Labels
type: documentation A change or addition to the documentation

Comments

@GeoGeorgeous
Copy link

GeoGeorgeous commented Jul 23, 2024

Change Type

Correction

Proposed Changes

Hey!

I've noticed that the directory apps/www/** was recently renamed to sites/docs/**, which has resulted in broken links across the site.

This affects the Component Source links on component pages in /docs, as well as the View Code links for examples.

For instance:

  1. The Component Source button for the Accordion component still leads to
    https://github.com/huntabyte/shadcn-svelte/tree/main/apps/www/src/lib/registry/default/ui/accordion
    instead of the correct
    https://github.com/huntabyte/shadcn-svelte/tree/main/sites/docs/src/lib/registry/default/ui/accordion

  2. The Tasks example View Code link still points to
    https://github.com/huntabyte/shadcn-svelte/tree/main/apps/www/src/routes/(app)/examples/tasks
    instead of the correct
    https://github.com/huntabyte/shadcn-svelte/tree/main/sites/docs/src/routes/(app)/examples/tasks

Hope it helps

@GeoGeorgeous GeoGeorgeous added the type: documentation A change or addition to the documentation label Jul 23, 2024
@shyakadavis
Copy link
Contributor

This is odd... had a look and couldn't find any reference to those links.

[Speculation]: Could it be that these new changes weren't built and deployed, and what we see on https://www.shadcn-svelte.com/docs/components/accordion, is an old deployment?

@shyakadavis
Copy link
Contributor

The correct previews are now live. I believe this can be closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: documentation A change or addition to the documentation
Projects
None yet
Development

No branches or pull requests

3 participants