Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add icons page #15

Merged
merged 20 commits into from
Jul 27, 2024
Merged

feat: add icons page #15

merged 20 commits into from
Jul 27, 2024

Conversation

ddtamn
Copy link
Contributor

@ddtamn ddtamn commented Jul 23, 2024

No description provided.

@shyakadavis
Copy link
Owner

shyakadavis commented Jul 23, 2024

Hello, @ddtamn

Thank you for the P.R.

In the spirit of mirroring the original, I was wondering if we could add more features, like the context menu, icon names...

If you are busy at the moment, then with your permission, I could help by committing directly to this P.R.

What do you think?

Thanks again.

@ddtamn
Copy link
Contributor Author

ddtamn commented Jul 24, 2024

Hello, @shyakadavis

Thank you for your feedback.

I completely agree with your suggestion to add more features, such as the context menu and icon names. I am currently a bit busy, but I will try to make some commits when I have free time. However, you are welcome to commit directly to this P.R. if needed.

Thanks again!

Copy link

github-actions bot commented Jul 24, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
geist ✅ Ready (View Log) Visit Preview 39561e7

@shyakadavis
Copy link
Owner

Hmm... the preview deployment is wrong. I'll keep investigating why it's not deploying the current branch with its changes.

@shyakadavis
Copy link
Owner

Could be related: huntabyte/shadcn-svelte#1204 in that I'm using their workflows in order to get forked-repo previews.

@github-actions github-actions bot requested a deployment to Preview July 24, 2024 16:19 Abandoned
@shyakadavis
Copy link
Owner

The correct deployment previews are now live. I wanted to add the search feature before merging, but IMO, good to go for now.

@shyakadavis shyakadavis merged commit 3e96952 into shyakadavis:main Jul 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants