You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request addresses issue #1059 by introducing a persistent package manager selection feature. The user's chosen package manager is now saved and automatically used across pages within a session, improving user experience and reducing friction.
Key Improvements:
Dynamic Command Selection: The component now dynamically updates the selectedCommand value when a command is copied.
UI Enhancements: The button's UI has been improved to display the selected command with the CaretSort icon, providing a clearer visual indication.
Bug Fixes: The handleCopyDone function has been corrected to ensure accurate updating of the selectedCommand value.
Persistent Package Manager Selection: User preferences for the package manager are now stored using a writable store for easy retrieval. This eliminates the need for repeated prompts and improves user experience.
Changes:
Integrated selectedCommand writable store to manage user preferences.
Updated copy-button.svelte to use the selected package manager and dynamically update selectedCommand.
Enhanced UI to display the selected command with CaretSort icon and allow modification of the package manager.
Fixed handleCopyDone function for accurate selectedCommand updates.
Testing:
Thoroughly tested the component's functionality to ensure the selected package manager is persisted across pages, and selectedCommand is updated correctly.
Verified that the UI changes are visually appealing and provide a clear indication of the selected command and package manager.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
…t" for improved UI consistency
📝 (copy-button.svelte): Update copy string to improve accessibility and clarity of purpose🎨 (copy-button.svelte): Update copy-button component styles for better UI consistency and accessibility
Closing for #1257 as you opened this PR on your main branch and it doesn't let me push changes easily to the PR. Your original commits are still included in the new PR though 😃
Thanks a ton for this! I added some improvements to actually render the correct commands in the code blocks based on the PM!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request addresses issue #1059 by introducing a persistent package manager selection feature. The user's chosen package manager is now saved and automatically used across pages within a session, improving user experience and reducing friction.
Key Improvements:
selectedCommandvalue when a command is copied.CaretSorticon, providing a clearer visual indication.handleCopyDonefunction has been corrected to ensure accurate updating of theselectedCommandvalue.Changes:
selectedCommandwritable store to manage user preferences.copy-button.svelteto use the selected package manager and dynamically updateselectedCommand.CaretSorticon and allow modification of the package manager.handleCopyDonefunction for accurateselectedCommandupdates.Testing:
selectedCommandis updated correctly.Showcase
Screencast.from.2024-08-24.09-57-28.webm