Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update tabindex attributes to use numbers #1402

Merged
merged 1 commit into from
Oct 30, 2024
Merged

fix: update tabindex attributes to use numbers #1402

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions sites/docs/src/lib/components/docs/copy-button.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,8 +76,8 @@
>
<span class="sr-only">Copy</span>
{#if copied}
<Check class="h-3 w-3" tabindex="-1" />
<Check class="h-3 w-3" tabindex={-1} />
{:else}
<Copy class="h-3 w-3" tabindex="-1" />
<Copy class="h-3 w-3" tabindex={-1} />
{/if}
</button>
4 changes: 2 additions & 2 deletions sites/docs/src/lib/registry/new-york/example/breadcrumb-dropdown.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<DropdownMenu.Root>
<DropdownMenu.Trigger class="flex items-center gap-1">
Components
<ChevronDown tabindex="-1" />
<ChevronDown tabindex={-1} />
</DropdownMenu.Trigger>
<DropdownMenu.Content align="start">
<DropdownMenu.Item>Documentation</DropdownMenu.Item>
Expand All @@ -27,7 +27,7 @@
</DropdownMenu.Root>
</Breadcrumb.Item>
<Breadcrumb.Separator>
<Slash tabindex="-1" />
<Slash tabindex={-1} />
</Breadcrumb.Separator>
<Breadcrumb.Item>
<Breadcrumb.Page>Breadcrumb</Breadcrumb.Page>
Expand Down
4 changes: 2 additions & 2 deletions sites/docs/src/lib/registry/new-york/example/breadcrumb-separator.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,13 +9,13 @@
<Breadcrumb.Link href="/">Home</Breadcrumb.Link>
</Breadcrumb.Item>
<Breadcrumb.Separator>
<Slash tabindex="-1" />
<Slash tabindex={-1} />
</Breadcrumb.Separator>
<Breadcrumb.Item>
<Breadcrumb.Link href="/components">Components</Breadcrumb.Link>
</Breadcrumb.Item>
<Breadcrumb.Separator>
<Slash tabindex="-1" />
<Slash tabindex={-1} />
</Breadcrumb.Separator>
<Breadcrumb.Item>
<Breadcrumb.Page>Breadcrumb</Breadcrumb.Page>
Expand Down
2 changes: 1 addition & 1 deletion sites/docs/src/lib/registry/new-york/ui/breadcrumb/breadcrumb-ellipsis.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,6 @@
class={cn("flex size-9 items-center justify-center", className)}
{...restProps}
>
<DotsHorizontal class="size-4 outline-none" tabindex="-1" />
<DotsHorizontal class="size-4 outline-none" tabindex={-1} />
<span class="sr-only">More</span>
</span>