Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(next): Update command doesn't update component code #1421

Merged
merged 13 commits into from
Nov 7, 2024

Conversation

ieedan
Copy link
Contributor

@ieedan ieedan commented Nov 1, 2024

If you ran npx shadcn-svelte@next update before you would notice that even though it completes successfully it doesn't actually update the code for any components.

PS: This sounds super rude reading it back but I can't think of a better way to word it so it's really not intentional

Copy link

changeset-bot bot commented Nov 1, 2024

🦋 Changeset detected

Latest commit: 23b5236

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
shadcn-svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 1, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
shadcn-svelte ✅ Ready (View Log) Visit Preview c3772e6

@ieedan
Copy link
Contributor Author

ieedan commented Nov 1, 2024

I am going to try and add a few tests before it merges working on that now

@ieedan
Copy link
Contributor Author

ieedan commented Nov 1, 2024

Tests are done so should be all good now!

@ieedan
Copy link
Contributor Author

ieedan commented Nov 1, 2024

@huntabyte Let me know if I should take a look at #1368.

Is the expected behavior to just remove utils from the update list or should we actually make it work?

@ieedan
Copy link
Contributor Author

ieedan commented Nov 1, 2024

@huntabyte Let me know if I should take a look at #1368.

Is the expected behavior to just remove utils from the update list or should we actually make it work?

For now I just made it so that if the user selected utils we just remove utils from the end of the selectedComponents array so that we don't try and later fetch it from the registry.

@ieedan
Copy link
Contributor Author

ieedan commented Nov 1, 2024

fixes #1368

@huntabyte
Copy link
Owner

Thanks @ieedan! We've discussed removing the update command altogether as it is a bit redundant to add, but I'm going to let @AdrianGonz97 make the call on this one.

@ablesea
Copy link

ablesea commented Nov 1, 2024

Thanks @ieedan! We've discussed removing the update command altogether as it is a bit redundant to add, but I'm going to let @AdrianGonz97 make the call on this one.

I think it is still useful especially when I have a big project and I don't want to type out every component it's a bit more ergonomic to choose each component to update.

@AdrianGonz97
Copy link
Collaborator

Thanks for the PR! I'll be sure to give this a review over the weekend

@ieedan ieedan mentioned this pull request Nov 5, 2024
@AdrianGonz97
Copy link
Collaborator

this is excellent. thank you!!

@AdrianGonz97 AdrianGonz97 merged commit e29f8f5 into huntabyte:next Nov 7, 2024
4 checks passed
@ieedan ieedan deleted the fix-update-command branch November 7, 2024 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants