Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes closeOnOutsideClick for nested drawers #102

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

thedivtagguy
Copy link

Improves the logic for handling nested drawer closures by using explicit index checking instead of direct ID comparison. This ensures only the topmost drawer closes when clicking outside, while maintaining parent drawers in their open state.

- const isLast = $openDialogIds[$openDialogIds.length - 1] === get(drawerId);
+ const currentIndex = $openDialogIds.indexOf(currentId);
+ if (currentIndex === $openDialogIds.length - 1) {

Fixes #74

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
vaul-svelte ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 4, 2024 6:47am

Copy link

changeset-bot bot commented Nov 3, 2024

⚠️ No Changeset found

Latest commit: 2565ae7

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

close on outside click doesn't work for nested drawers
1 participant